lkml.org 
[lkml]   [2016]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] cxl: Delete an unnecessary check before the function call "of_node_put"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 20 Jul 2016 15:10:32 +0200

    The of_node_put() function tests whether its argument is NULL
    and then returns immediately.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/misc/cxl/of.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/misc/cxl/of.c b/drivers/misc/cxl/of.c
    index edc4583..333256a 100644
    --- a/drivers/misc/cxl/of.c
    +++ b/drivers/misc/cxl/of.c
    @@ -490,8 +490,7 @@ int cxl_of_probe(struct platform_device *pdev)
    adapter->slices = 0;
    }

    - if (afu_np)
    - of_node_put(afu_np);
    + of_node_put(afu_np);
    return 0;
    }

    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-20 16:01    [W:4.057 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site