lkml.org 
[lkml]   [2016]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH v2 3/3] xen-scsiback: Pass a failure indication as a constant
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 20 Jul 2016 13:12:33 +0200

    Pass the constant "FAILED" in a function call directly instead of
    using an intialisation for a local variable.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    v2: Rebased on source files from "Linux next-20160719"

    drivers/xen/xen-scsiback.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
    index eb274df..fa08ec6 100644
    --- a/drivers/xen/xen-scsiback.c
    +++ b/drivers/xen/xen-scsiback.c
    @@ -601,7 +601,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req,
    struct se_cmd *se_cmd = &pending_req->se_cmd;
    struct scsiback_tmr *tmr;
    u64 unpacked_lun = pending_req->v2p->lun;
    - int rc, err = FAILED;
    + int rc, err;

    tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL);
    if (!tmr)
    @@ -628,7 +628,7 @@ put_cmd:
    target_put_sess_cmd(se_cmd);
    free_tmr:
    kfree(tmr);
    - scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
    + scsiback_do_resp_with_sense(NULL, FAILED, 0, pending_req);
    }

    /*
    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-20 14:21    [W:4.095 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site