Messages in this thread | | | From | Christian Gmeiner <> | Date | Sat, 2 Jul 2016 15:26:00 +0200 | Subject | Re: [PATCH] spi: imx: wait_for_completion_timeout(..) for PIO transfers |
| |
Hi Mark,
2016-07-01 17:01 GMT+02:00 Mark Brown <broonie@kernel.org>: > On Fri, Jul 01, 2016 at 02:32:58PM +0200, Christian Gmeiner wrote: >> In some rare cases I see the following 'task blocked' information. It >> looks like the PIO transfer has some problems and never succeeds. Make >> use of wait_for_completion_timeout(..) to detect this case and >> return -ETIMEDOUT. >> >> v2: remove backtrace from commit message > > Please do not submit new versions of already applied patches, please > submit incremental updates to the existing code. Modifying existing > commits creates problems for other users building on top of those > commits so it's best practice to only change pubished git commits if > absolutely essential. >
I was not aware that the patch was applied already that is why I send out a v2. I normally do not follow any subsystem or linux-next tree to see if a patch of me got applied or not. Normally I get an Acked-by: or Signed-off-by: reply to know about the state of the patch. In case of this patch I got a separate main 'Applied "spi: imx: wait_for_completion_timeout(..) for PIO transfers" to the spi tree' which did not get any attention from me as it was hidden due some gmail filter-to-label rules. In the end I am happy that this patch got applied. Thanks for that and sorry that I have stolen to much time.
> If you're including an inter-version changelog please keep it after the > --- as covered in SubmittingPatches.
Will do the next time - sorry for that.
greets -- Christian Gmeiner, MSc
https://soundcloud.com/christian-gmeiner
| |