Messages in this thread | | | Date | Tue, 19 Jul 2016 19:50:27 -0700 | From | Brian Norris <> | Subject | Re: [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM |
| |
On Wed, Jul 20, 2016 at 03:50:27AM +0200, Marek Vasut wrote: > On 07/19/2016 10:05 PM, Brian Norris wrote: > > On Tue, Jul 19, 2016 at 08:03:00AM +0200, Stefan Roese wrote: > >> On 18.07.2016 22:20, Brian Norris wrote: > >>> Hmm, does x86 not define readsl()/writesl()? I can never tell what > >>> accessors are supposed to be "standard" across architectures. > >>> > >>> Either we need to drop the COMPILE_TEST or maybe make it (!X86 && > >>> COMPILE_TEST). > >> > >> iowrite32_rep() etc should work for x86 as well. > > > > Looks like it might. I'm not sure the original submitter can retest > > right now (travel), so I'd probably rather just take the easy fix for > > now, and we can widen to COMPILE_TEST later if desired. > > Isn't there a generic readsl() and writesl() implementation in > include/asm-generic/io.h ?
Yes, but somehow x86 has managed to avoid that. I guess it's optional for arch/<foo>/include/asm/io.h to include <asm-generic/io.h>? At any rate, I double-checked myself by adding '#error "blah"' to include/asm-generic/io.h, and x86 still seemed to build fine (at least for the modules I was checking, like cadence-quadspi.o).
> > If I could get an ack on something like this, I'll apply it soon: > > This is fine, I am making a note to revisit this.
Cool. In that case...
> > ---8<--- > > From: Brian Norris <computersforpeace@gmail.com> > > Date: Tue, 19 Jul 2016 13:02:40 -0700 > > Subject: [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM > > > > This controller driver is used only on ARM but is mostly written > > portably so it can build on other arch'es. Unfortunately, at least x86 > > doesn't provibe readsl()/writesl() accessors. We could possibly fix this > > issue in the future by using io{read,write}32_rep() instead, but let's > > just drop the architectures we aren't using for now. > > > > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Applied.
Brian
| |