lkml.org 
[lkml]   [2016]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 1/5] tpm/st33zp24: Remove useless tpm_gen_interrupt
    Date
    From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

    This function should only be called as part of an IRQ probing protocol
    and st33 does not have any code to detect that the IRQ it tries to
    generate was not generated and disable the IRQ.

    Since st33 is primarily a DT binding driver it should not be doing
    IRQ probing anyhow, so let us just delete this useless call.

    Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
    Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    ---
    drivers/char/tpm/st33zp24/st33zp24.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c
    index c2ee304..6f060c7 100644
    --- a/drivers/char/tpm/st33zp24/st33zp24.c
    +++ b/drivers/char/tpm/st33zp24/st33zp24.c
    @@ -589,8 +589,6 @@ int st33zp24_probe(void *phy_id, const struct st33zp24_phy_ops *ops,
    chip->flags |= TPM_CHIP_FLAG_IRQ;

    disable_irq_nosync(tpm_dev->irq);
    -
    - tpm_gen_interrupt(chip);
    }

    return tpm_chip_register(chip);
    --
    2.7.4
    \
     
     \ /
      Last update: 2016-07-20 02:21    [W:2.334 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site