Messages in this thread | | | Subject | Re: [PATCH] [media] gspca: finepix: Remove deprecated create_singlethread_workqueue | From | Frank Zago <> | Date | Mon, 18 Jul 2016 21:36:23 -0500 |
| |
On 07/16/2016 03:55 AM, Bhaktipriya Shridhar wrote: > The workqueue "work_thread" is involved in streaming the camera data. > It has a single work item(&dev->work_struct) and hence doesn't require > ordering. Also, it is not being used on a memory reclaim path. > Hence, the singlethreaded workqueue has been replaced with the use of > system_wq. > > System workqueues have been able to handle high level of concurrency > for a long time now and hence it's not required to have a singlethreaded > workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue > created with create_singlethread_workqueue(), system_wq allows multiple > work items to overlap executions even on the same CPU; however, a > per-cpu workqueue doesn't have any CPU locality or global ordering > guarantee unless the target CPU is explicitly specified and thus the > increase of local concurrency shouldn't make any difference. > > Work item has been flushed in sd_stop0() to ensure that there are no > pending tasks while disconnecting the driver. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Frank Zago <frank@zago.net>
Thanks for the patch.
| |