lkml.org 
[lkml]   [2016]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] tpm: support driver-specific sysfs attrs in tpm_tis_core
On Mon, Jul 18, 2016 at 10:11:41PM +0300, Jarkko Sakkinen wrote:
> On Thu, Jul 14, 2016 at 06:51:36PM -0700, Andrey Pronin wrote:
> > Add attr_group to phy_ops that a driver relying on tpm_tis_core_init
> > can set to have its specific attributes registered in sysfs.
> >
> > Signed-off-by: Andrey Pronin <apronin@chromium.org>
> > ---
> > drivers/char/tpm/tpm-sysfs.c | 1 -
> > drivers/char/tpm/tpm.h | 8 +++++++-
> > drivers/char/tpm/tpm_tis_core.c | 3 +++
> > drivers/char/tpm/tpm_tis_core.h | 1 +
> > 4 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c
> > index 95ce90d..22c9874 100644
> > --- a/drivers/char/tpm/tpm-sysfs.c
> > +++ b/drivers/char/tpm/tpm-sysfs.c
> > @@ -304,7 +304,6 @@ void tpm_sysfs_add_device(struct tpm_chip *chip)
> > * is called before ops is null'd and the sysfs core synchronizes this
> > * removal so that no callbacks are running or can run again
> > */
> > - WARN_ON(chip->groups_cnt != 0);
>
> You should explain this in a commit message if you want to remove it.
>
> In general, this make user space API vendor specific, which is
> unacceptable.
>
> /Jarkko
>

I will drop the vendor-specific part of the patchset and just submit
tpm2-specific sysfs attributes in the next rev. WARN_ON will not be
removed.

\
 
 \ /
  Last update: 2016-07-18 21:41    [W:0.057 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site