lkml.org 
[lkml]   [2016]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 1/7] k3dma: Fix hisi burst clipping


    On 07/16/2016 10:13 AM, John Stultz wrote:
    > From: Andy Green <andy.green@linaro.org>
    >
    > Max burst len is a 4-bit field, but at the moment it's clipped with
    > a 5-bit constant... reduce it to that which can be expressed
    >
    > Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
    > Cc: Jingoo Han <jg1.han@samsung.com>
    > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    > Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
    > Cc: Vinod Koul <vinod.koul@intel.com>
    > Cc: Dan Williams <dan.j.williams@intel.com>
    > Cc: Liam Girdwood <lgirdwood@gmail.com>
    > Cc: Mark Brown <broonie@kernel.org>
    > Cc: Jaroslav Kysela <perex@perex.cz>
    > Cc: Takashi Iwai <tiwai@suse.com>
    > Cc: Wei Xu <xuwei5@hisilicon.com>
    > Cc: Rob Herring <robh+dt@kernel.org>
    > Cc: Andy Green <andy@warmcat.com>
    > Cc: Dave Long <dave.long@linaro.org>
    > Cc: Guodong Xu <guodong.xu@linaro.org>
    > Signed-off-by: Andy Green <andy.green@linaro.org>
    > [jstultz: Forward ported to mainline]
    > Signed-off-by: John Stultz <john.stultz@linaro.org>

    Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>

    > ---
    > drivers/dma/k3dma.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
    > index 1ba2fd7..d01a11d 100644
    > --- a/drivers/dma/k3dma.c
    > +++ b/drivers/dma/k3dma.c
    > @@ -552,7 +552,7 @@ static int k3_dma_config(struct dma_chan *chan,
    > c->ccfg |= (val << 12) | (val << 16);
    >
    > if ((maxburst == 0) || (maxburst > 16))
    > - val = 16;
    > + val = 15;
    > else
    > val = maxburst - 1;
    > c->ccfg |= (val << 20) | (val << 24);
    >

    \
     
     \ /
      Last update: 2016-07-18 09:21    [W:4.383 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site