lkml.org 
[lkml]   [2016]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 7/7] dts: hi6220: Add k3-dma and i2s/hdmi audio support
On Sat, Jul 16, 2016 at 4:48 AM, Mark Brown <broonie@kernel.org> wrote:
> On Fri, Jul 15, 2016 at 07:13:27PM -0700, John Stultz wrote:
>
>> Add entry for k3-dma driver and i2s/hdmi audio devices.
>
>> This enables HDMI audio output.
>
> These bindings appear to be undocumented. All new bindings require
> documentation.

Yea. I figured there would be potentially substantial enough changes
required that doing a initial draft (which given my limited knowledge
of the hardware, would be mostly boilerplate) might not be worth it
for the first RFC.

>> + i2s0: hi6210_i2s {
>> + compatible = "hisilicon,hi6210-i2s";
>> + reg = <0x0 0xf7118000 0x0 0x8000>, /* i2s unit */
>> + <0x0 0xf7030000 0x0 0x400>, /* syscon */
>> + <0x0 0xf7032000 0x0 0x400>; /* pmctrl */
>
> Some of this looks like we should be using a system controller binding
> rather than listing the system controller directly here. The magic
> number indexing for the resources is also not good, we should be using
> reg-names to get name based lookups (I had been going to query that on
> the binding document when I failed to find it...).

Ok. I'll need to dig a bit to understand it better, but will try to
address this.

thanks
-john

\
 
 \ /
  Last update: 2016-07-18 20:01    [W:0.046 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site