Messages in this thread | | | Subject | Re: [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity | From | Xunlei Pang <> | Date | Mon, 18 Jul 2016 21:37:07 +0800 |
| |
On 2016/07/18 at 21:04, Juri Lelli wrote: > On 15/07/16 18:39, Xunlei Pang wrote: >> On 2016/07/13 at 18:58, Juri Lelli wrote: > [...] > >> Since this is only called for queued cases now, there is no need to >> check boosted stuff here. As enqueue_task(ENQUEUE_REPLENISH) >> is called before check_class_changed() in rt_mutex_setprio(). >> > But we don't do the same in setscheduler, right?
If p is deadline PI-boosted, setscheduler() won't call change its sched_class. If p isn't deadline PI-boosted, then pi_task is NULL.
So, I think the added code won't hit. Did I miss something?
Regards, Xunlei
| |