lkml.org 
[lkml]   [2016]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drm/hdlcd: Delete an unnecessary check before drm_fbdev_cma_hotplug_event()
    On Sat, Jul 16, 2016 at 09:20:02AM +0200, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sat, 16 Jul 2016 09:10:40 +0200
    >
    > The drm_fbdev_cma_hotplug_event() function tests whether its argument
    > is NULL and then returns immediately.
    > Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

    Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

    > ---
    > drivers/gpu/drm/arm/hdlcd_drv.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
    > index 28b8cd1..9b1aefe 100644
    > --- a/drivers/gpu/drm/arm/hdlcd_drv.c
    > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
    > @@ -102,8 +102,7 @@ static void hdlcd_fb_output_poll_changed(struct drm_device *drm)
    > {
    > struct hdlcd_drm_private *hdlcd = drm->dev_private;
    >
    > - if (hdlcd->fbdev)
    > - drm_fbdev_cma_hotplug_event(hdlcd->fbdev);
    > + drm_fbdev_cma_hotplug_event(hdlcd->fbdev);
    > }
    >
    > static const struct drm_mode_config_funcs hdlcd_mode_config_funcs = {
    > --
    > 2.9.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    --
    ====================
    | I would like to |
    | fix the world, |
    | but they're not |
    | giving me the |
    \ source code! /
    ---------------
    ¯\_(ツ)_/¯

    \
     
     \ /
      Last update: 2016-07-18 12:01    [W:4.089 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site