Messages in this thread Patch in this message | | | Subject | [PATCH] [media] tw686x-kh: Delete an unnecessary check before the function call "video_unregister_device" | From | SF Markus Elfring <> | Date | Sun, 17 Jul 2016 22:16:19 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 17 Jul 2016 22:00:35 +0200
The video_unregister_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/staging/media/tw686x-kh/tw686x-kh-video.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/tw686x-kh/tw686x-kh-video.c b/drivers/staging/media/tw686x-kh/tw686x-kh-video.c index 6ecb504..3f2830c 100644 --- a/drivers/staging/media/tw686x-kh/tw686x-kh-video.c +++ b/drivers/staging/media/tw686x-kh/tw686x-kh-video.c @@ -643,8 +643,7 @@ void tw686x_kh_video_free(struct tw686x_dev *dev) struct tw686x_video_channel *vc = &dev->video_channels[ch]; v4l2_ctrl_handler_free(&vc->ctrl_handler); - if (vc->device) - video_unregister_device(vc->device); + video_unregister_device(vc->device); vb2_dma_sg_cleanup_ctx(vc->alloc_ctx); for (n = 0; n < 2; n++) { struct dma_desc *descs = &vc->sg_tables[n]; -- 2.9.1
| |