lkml.org 
[lkml]   [2016]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] drm/ast: Delete an unnecessary check before drm_gem_object_unreference_unlocked()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 16 Jul 2016 09:54:22 +0200

    The drm_gem_object_unreference_unlocked() function tests whether
    its argument is NULL and then returns immediately.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/ast/ast_main.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
    index 7bc3aa6..904beaa 100644
    --- a/drivers/gpu/drm/ast/ast_main.c
    +++ b/drivers/gpu/drm/ast/ast_main.c
    @@ -295,9 +295,8 @@ static int ast_get_dram_info(struct drm_device *dev)
    static void ast_user_framebuffer_destroy(struct drm_framebuffer *fb)
    {
    struct ast_framebuffer *ast_fb = to_ast_framebuffer(fb);
    - if (ast_fb->obj)
    - drm_gem_object_unreference_unlocked(ast_fb->obj);

    + drm_gem_object_unreference_unlocked(ast_fb->obj);
    drm_framebuffer_cleanup(fb);
    kfree(fb);
    }
    --
    2.9.1
    \
     
     \ /
      Last update: 2016-07-16 10:41    [W:4.022 / U:0.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site