Messages in this thread | | | Date | Fri, 15 Jul 2016 17:00:57 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v16 00/15] perf tools: Support overwritable ring buffer |
| |
On Thu, Jul 14, 2016 at 08:34:32AM +0000, Wang Nan wrote:
SNIP
> > v15 -> v16: Follow Jiri Olsa's suggestion: > 1. Move backward ring buffer state machine to evlist. > 2. Dynamically allocate backward mmap, so backward_mmap == NULL > means there's no backward ring buffer. > Stop the state machine when there's no backward ring buffer. > 3. Rename: _output2 to _output_backward. > 4. Patch rearrangement. > 5. Update record__pick_pc(): read from backward_mmap if normal > mmap is empty. > > Arnaldo Carvalho de Melo (1): > perf tools: Drop redundant evsel->overwrite indicator > > Wang Nan (14): > tools lib fd array: Allow associating a pointer cookie with each entry > perf tools: Update perf evlist mmap related APIs and helpers > perf tools: Decouple record__mmap_read() and evlist. > perf tools: Record mmap cookie into fdarray private field > perf tools: Extract common code in mmap failure processing > perf tools: Introduce backward_mmap array for evlist > perf tools: Map backward events to backward_mmap > perf tools: Drop evlist->backward > perf tools: Setup backward mmap state machine > perf record: Read from overwritable ring buffer > perf tools: Make perf_evlist__{pause,resume} internal helpers > perf tools: Enable overwrite settings > perf tools: Don't warn about out of order event if write_backward is > used > perf tools: Add --tail-synthesize option
looks good to me now ;-)
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
| |