lkml.org 
[lkml]   [2016]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] drm/bochs: Delete an unnecessary check before drm_gem_object_unreference_unlocked()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 15 Jul 2016 14:23:15 +0200

    The drm_gem_object_unreference_unlocked() function tests whether
    its argument is NULL and then returns immediately.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/bochs/bochs_mm.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
    index 6cf912c..28a60a7 100644
    --- a/drivers/gpu/drm/bochs/bochs_mm.c
    +++ b/drivers/gpu/drm/bochs/bochs_mm.c
    @@ -474,8 +474,8 @@ int bochs_dumb_mmap_offset(struct drm_file *file, struct drm_device *dev,
    static void bochs_user_framebuffer_destroy(struct drm_framebuffer *fb)
    {
    struct bochs_framebuffer *bochs_fb = to_bochs_framebuffer(fb);
    - if (bochs_fb->obj)
    - drm_gem_object_unreference_unlocked(bochs_fb->obj);
    +
    + drm_gem_object_unreference_unlocked(bochs_fb->obj);
    drm_framebuffer_cleanup(fb);
    kfree(fb);
    }
    --
    2.9.1
    \
     
     \ /
      Last update: 2016-07-15 15:01    [W:4.092 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site