Messages in this thread | | | Date | Thu, 14 Jul 2016 20:44:44 -0700 | From | Andrey Pronin <> | Subject | Re: [PATCH 2/2] tpm: add driver for cr50 on SPI |
| |
On Thu, Jul 14, 2016 at 09:32:36PM -0600, Jason Gunthorpe wrote: > On Thu, Jul 14, 2016 at 07:20:18PM -0700, Andrey Pronin wrote: > > > +static int cr50_spi_read16(struct tpm_tis_data *data, u32 addr, u16 *result) > > +{ > > + int rc; > > + > > + rc = data->phy_ops->read_bytes(data, addr, sizeof(u16), (u8 *)result); > > + if (!rc) > > + *result = le16_to_cpu(*result); > > + return rc; > > +} > > I thought we had core support for this pattern? > > Christophe ? > > Please change this so this code isn't duplicated. > > Jason > Hmm, didn't see the support. Would be great if there is. The pattern itself is copied from tpm_tis_spi as is. read_bytes/write_bytes were de-dup'ed as they used a lot of common code (even more for this driver than for tpm_tis_spi). But as for _readNN/_writeNN, there're only three of these functions, so it din't seem too bad.
| |