lkml.org 
[lkml]   [2016]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/3] drm/msm: Delete unnecessary checks before drm_gem_object_unreference_unlocked()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 13 Jul 2016 19:15:35 +0200

    The drm_gem_object_unreference_unlocked() function tests whether
    its argument is NULL and then returns immediately.
    Thus the test around the calls is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 3 +--
    drivers/gpu/drm/msm/msm_fb.c | 4 ++--
    drivers/gpu/drm/msm/msm_gem.c | 4 +---
    3 files changed, 4 insertions(+), 7 deletions(-)

    diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c
    index ba8df15..7b39e89 100644
    --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c
    +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c
    @@ -168,8 +168,7 @@ static void mdp4_destroy(struct msm_kms *kms)

    if (mdp4_kms->blank_cursor_iova)
    msm_gem_put_iova(mdp4_kms->blank_cursor_bo, mdp4_kms->id);
    - if (mdp4_kms->blank_cursor_bo)
    - drm_gem_object_unreference_unlocked(mdp4_kms->blank_cursor_bo);
    + drm_gem_object_unreference_unlocked(mdp4_kms->blank_cursor_bo);

    if (mdp4_kms->rpm_enabled)
    pm_runtime_disable(dev);
    diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c
    index 7919c24..95cf8fe 100644
    --- a/drivers/gpu/drm/msm/msm_fb.c
    +++ b/drivers/gpu/drm/msm/msm_fb.c
    @@ -49,8 +49,8 @@ static void msm_framebuffer_destroy(struct drm_framebuffer *fb)

    for (i = 0; i < n; i++) {
    struct drm_gem_object *bo = msm_fb->planes[i];
    - if (bo)
    - drm_gem_object_unreference_unlocked(bo);
    +
    + drm_gem_object_unreference_unlocked(bo);
    }

    kfree(msm_fb);
    diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
    index 886cfe0..9a713fb 100644
    --- a/drivers/gpu/drm/msm/msm_gem.c
    +++ b/drivers/gpu/drm/msm/msm_gem.c
    @@ -875,8 +875,6 @@ struct drm_gem_object *msm_gem_import(struct drm_device *dev,
    return obj;

    fail:
    - if (obj)
    - drm_gem_object_unreference_unlocked(obj);
    -
    + drm_gem_object_unreference_unlocked(obj);
    return ERR_PTR(ret);
    }
    --
    2.9.0
    \
     
     \ /
      Last update: 2016-07-13 20:41    [W:4.280 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site