Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded | Date | Wed, 13 Jul 2016 09:50:53 +0300 |
| |
Prarit Bhargava <prarit@redhat.com> writes:
>> We implement thermal zone because we do support it, but the problem is >> that we need the firmware to be loaded for that. So you can argue that >> we should register *later* when the firmware is loaded. But this is >> really not helping all that much because the firmware can also be >> stopped at any time. So you'd want us to register / unregister the >> thermal zone anytime the firmware is loaded / unloaded? > > You might have to do that. I think that if the firmware enables a feature then > the act of loading the firmware should run the code that enables the feature. > IMO of course.
But I suspect that the iwlwifi firmware is loaded during interface up (and unloaded during interface down) and in that case register/unregister would be happening all the time. That doesn't sound like a good idea. I would rather try to fix the thermal interface to handle the cases when the measurement is not available.
-- Kalle Valo
| |