Messages in this thread | | | Subject | Re: [PATCH v3 3/4] perf annotate: add powerpc support | From | Ravi Bangoria <> | Date | Wed, 13 Jul 2016 14:59:23 +0530 |
| |
On Wednesday 13 July 2016 01:09 PM, Michael Ellerman wrote: > Arnaldo Carvalho de Melo <acme@kernel.org> writes: > >> Em Tue, Jul 12, 2016 at 07:51:46AM +0530, Ravi Bangoria escreveu: >>> Hi Arnaldo, >>> >>> On Friday 08 July 2016 02:01 PM, Michael Ellerman wrote: >>>> Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> writes: >>>> >>>>> On Wednesday 06 July 2016 03:38 PM, Michael Ellerman wrote: >>>>> >>>>> I've sent v4 which enables annotate for bctr' instructions. >>>>> >>>>> for 'bctr', it will show down arrow(indicate jump) and 'bctrl' will show >>>>> right arrow(indicate call). But no navigation options will be provided. >>>>> By pressing Enter key on that, message will be shown that like >>>>> "Invalid target" >>>> Great thanks. >>> I've sent v4 series. Please review it. >> If somebody else could do it and provide acks/reviewed by, that would >> help, >> >> Michael, can I get your comments as such? > It looks OK to me. But I don't know the code really, and I haven't had > time to test it personally. > > Ravi, have you tested on a big endian machine?
Yes Michael, I've tested annotate on BE and LE both.
-Ravi
> > cheers >
| |