lkml.org 
[lkml]   [2016]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: crypto: ux500 - memmove the right size
On Mon, Jul 11, 2016 at 04:40:34PM +0200, Toralf Förster wrote:
> While reading the comment to 19ced623d :
>
> " The hash buffer is really HASH_BLOCK_SIZE bytes, someone
> must have thought that memmove takes n*u32 words by mistake.
> Tests work as good/bad as before after this patch.
> "
>
> I was just curious why the tests doesn't fail now and since when the bug were in the code.
> The answer to the later is simple - the bug is there since the beginning of that file.
> What's do you think about the first question ?

The tests do/can not cover every possible execution path. Of course
if you can write a simple vector/test that covers this case that
would be very nice.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2016-07-12 07:21    [W:0.233 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site