lkml.org 
[lkml]   [2016]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo
    On Mon, Jul 11, 2016 at 02:50:08PM -0700, Stephen Boyd wrote:
    > The voltage ranges listed here are wrong. The pma8084 pldo
    > supports three different overlapping voltage ranges with
    > differing step sizes and the pma8084 ftsmps supports two. These
    > ranges can be seen in the "native" spmi regulator driver
    > (qcom_spmi-regulator.c) at pldo_ranges[] and ftsmps_ranges[]
    > respectively. Port these ranges over to the RPM SMD regulator
    > driver so that we list the appropriate set of supported voltages
    > on these types of regulators.
    >
    > Cc: Andy Gross <andy.gross@linaro.org>
    > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
    > Fixes: ee01d0c91ef1 ("regulator: qcom-smd: Add support for PMA8084")
    > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

    <snip>

    > static const struct regulator_desc pma8084_pldo = {
    > .linear_ranges = (struct regulator_linear_range[]) {
    > - REGULATOR_LINEAR_RANGE(750000, 0, 30, 25000),
    > - REGULATOR_LINEAR_RANGE(1500000, 31, 99, 50000),
    > + REGULATOR_LINEAR_RANGE( 750000, 0, 63, 12500),

    It was my understanding that the PMOS ldos only support 25mV and 50mV
    incremements.

    > + REGULATOR_LINEAR_RANGE(1550000, 64, 126, 25000),
    > + REGULATOR_LINEAR_RANGE(3100000, 127, 163, 50000),
    > },
    > - .n_linear_ranges = 2,
    > - .n_voltages = 100,
    > + .n_linear_ranges = 3,
    > + .n_voltages = 164,
    > .ops = &rpm_smps_ldo_ops,

    Regards,

    Andy

    \
     
     \ /
      Last update: 2016-07-12 01:21    [W:3.761 / U:1.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site