Messages in this thread | | | Date | Mon, 11 Jul 2016 08:37:31 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH 1/3] Add a new field to struct shrinker |
| |
On Sat 09-07-16 04:43:31, Janani Ravichandran wrote: > Struct shrinker does not have a field to uniquely identify the shrinkers > it represents. It would be helpful to have a new field to hold names of > shrinkers. This information would be useful while analyzing their > behavior using tracepoints.
This will however increase the vmlinux size even when no tracing is enabled. Why cannot we simply print the name of the shrinker callbacks?
> > --- > include/linux/shrinker.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h > index 4fcacd9..431125c 100644 > --- a/include/linux/shrinker.h > +++ b/include/linux/shrinker.h > @@ -52,6 +52,7 @@ struct shrinker { > unsigned long (*scan_objects)(struct shrinker *, > struct shrink_control *sc); > > + const char *name; > int seeks; /* seeks to recreate an obj */ > long batch; /* reclaim batch size, 0 = default */ > unsigned long flags; > -- > 2.7.0 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
-- Michal Hocko SUSE Labs
| |