lkml.org 
[lkml]   [2016]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 09/10] Documentation: devicetree: Add dts description for nuc900
    Date
    On Sunday, July 10, 2016 3:42:21 PM CEST Wan Zongshun wrote:
    > +
    > +Required properties:
    > +- compatible : Should be "nuvoton,nuc970-tmr"
    > +- reg : Address and length of the register set
    > +- clocks : Reference on the timer input clock
    > +- interrupts : Reference to the timer interrupt
    > +
    > +Example:
    > +
    > +tmr@0xb8001000 {

    The name should be "timer", not "tmr", and the address should
    not contain a leading "0x".

    > + compatible = "nuvoton,nuc970-tmr";
    > + reg = <0xb8001000 0x1000>;
    > + interrupts = <16>;
    > + clocks = <&clks TIMER0_GATE>,
    > + <&clks TIMER1_GATE>;
    > + clock-names = "timer0", "timer1";
    > +};

    The clocks/clock-names description does not match the example:
    you only define a single clock in the required properties, but
    have two separate inputs in the example. Please fix one or the
    other.

    Arnd

    \
     
     \ /
      Last update: 2016-07-11 00:41    [W:3.417 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site