Messages in this thread | | | Subject | Re: [PATCH v1 03/11] KVM: x86: dynamic kvm_apic_map | From | Paolo Bonzini <> | Date | Fri, 1 Jul 2016 18:38:00 +0200 |
| |
On 01/07/2016 17:43, Radim Krčmář wrote: > > Forgot to reply about this: letting SET_LAPIC change x2APIC IDs is nonsense. > > > > In x2APIC mode + new capability disabled SET_LAPIC should ignore the id > > register altogether for backwards compatibility. > > I'd still shift SET_LAPIC APIC ID to have internal APIC ID register in > hardware-compatible format.
With the capability disabled, APIC ID should always be in bits 31-24 for both GET and SET. But I think we agree, it's simpler to reason in v2 code and testcases. :)
Paolo
| |