lkml.org 
[lkml]   [2016]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 06/11] KVM: x86: use hardware-compatible format for APIC ID register
From
Date


On 01/07/2016 17:53, Radim Krčmář wrote:
>> >> enable_xapic()
>> >> id = apic_id()
>> >> set_apic_id(id+1) // ?
>> >> enable_x2apic()
>> >> id == apic_id() & 0xff
>> >> disable_apic()
>> >> enable_xapic()
>> >> id == apic_id()
>> >>
> >
> > Yes, plus checking that it "moves" appropriately between low and high bits.
>
> x2APIC cannot use MMIO interface, so apic_id() already does the best we
> can ... if KVM is shifting wrong somwhere, then the id should differ.

Yeah, fair enough.

Paolo

\
 
 \ /
  Last update: 2016-07-01 19:21    [W:0.069 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site