Messages in this thread | | | Date | Fri, 1 Jul 2016 15:17:44 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH] drm/tegra: add missing include |
| |
On Fri, Jul 01, 2016 at 12:16:20PM +0200, Arnd Bergmann wrote: > A newly merged patch to configure the XBAR caused a build failure > in some configurations: > > drivers/gpu/drm/tegra/sor.c: In function 'tegra_sor_set_pinmux': > drivers/gpu/drm/tegra/sor.c:252:10: error: implicit declaration of function 'pinctrl_lookup_state' [-Werror=implicit-function-declaration] > state = pinctrl_lookup_state(sor->pinctrl, name); > ^~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/tegra/sor.c:252:8: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] > state = pinctrl_lookup_state(sor->pinctrl, name); > > The functions are declared in linux/pinctrl/consumer.h, so we need > to include that file instead of relying on the inclusion to happen > through another header. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 9e9d1315f4f4 ("drm/tegra: sor: Make XBAR configurable per SoC") > --- > drivers/gpu/drm/tegra/sor.c | 1 + > 1 file changed, 1 insertion(+)
This was actually introduced in 035f79bcd5e5 ("drm/tegra: sor: Support DPAUX pin control"), which is causing other problems at runtime, so I've backed it out again.
Thanks, Thierry [unhandled content-type:application/pgp-signature] | |