Messages in this thread | | | Subject | Re: [PATCH 0/3] add support for Allwinner SoCs ADC | From | Quentin Schulz <> | Date | Fri, 1 Jul 2016 11:45:23 +0200 |
| |
On 29/06/2016 05:28, Chen-Yu Tsai wrote: > Hi, > > On Tue, Jun 28, 2016 at 4:45 PM, Quentin Schulz > <quentin.schulz@free-electrons.com> wrote: >> The Allwinner SoCs all have an ADC that can also act as a touchscreen controller >> and a thermal sensor. The first four channels can be used either for the ADC or >> the touchscreen and the fifth channel is used for the thermal sensor. We >> currently have a driver for the two latter functions in >> drivers/input/touchscreen/sun4i-ts.c but we don't have access to the ADC feature >> at all. >> >> This adds initial support for Allwinner SoCs ADC with all features. Yet, the >> touchscreen is not implemented but will be added later. To switch between >> touchscreen and ADC modes, you need to poke few bits in registers and >> (de)activate an interrupt (pen-up). >> A MFD is provided to let the input driver activate the pen-up interrupt through >> virtual interrupt, poke few bits via regmap and read data from the ADC driver >> while both (and iio_hwmon) are probed by the MFD. > > I take it that we are going to replace the original sun4i-ts driver > with this new mfd one, and various sub device drivers? >
Yes, that's the spirit.
[...]
> One thing about iio-hwmon is that it doesn't support hwmon labels. > Any chance you could improve this, so we see the same names in userspace?
Should be an easy patch: reading datasheet_name from iio_chan_spec of the iio_channel in iio_hwmon_probe, if none then fall back to current naming convention.
I don't think it is linked to this serie of patches so I prefer to look at it later.
Thanks!
| |