lkml.org 
[lkml]   [2016]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 003/206] ath10k: fix debugfs pktlog_filter write
    Date
    4.2.8-ckt12 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Anilkumar Kolli <akolli@qti.qualcomm.com>

    commit 9ddc486aa09a3413a6c492fcf160ce61bfccb7b1 upstream.

    It is observed that, we are disabling the packet log if we write same
    value to the pktlog_filter for the second time. Always enable pktlogs
    on non zero filter.

    Fixes: 90174455ae05 ("ath10k: add support to configure pktlog filter")
    Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com>
    Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/net/wireless/ath/ath10k/debug.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
    index 8fa606a..bfb605b 100644
    --- a/drivers/net/wireless/ath/ath10k/debug.c
    +++ b/drivers/net/wireless/ath/ath10k/debug.c
    @@ -2004,7 +2004,12 @@ static ssize_t ath10k_write_pktlog_filter(struct file *file,
    goto out;
    }

    - if (filter && (filter != ar->debug.pktlog_filter)) {
    + if (filter == ar->debug.pktlog_filter) {
    + ret = count;
    + goto out;
    + }
    +
    + if (filter) {
    ret = ath10k_wmi_pdev_pktlog_enable(ar, filter);
    if (ret) {
    ath10k_warn(ar, "failed to enable pktlog filter %x: %d\n",
    --
    2.7.4
    \
     
     \ /
      Last update: 2016-06-10 01:01    [W:4.129 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site