lkml.org 
[lkml]   [2016]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 158/206] mfd: lp8788-irq: Uninitialized variable in irq handler
    Date
    4.2.8-ckt12 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 22aab38e7b59fd79ce1045006be69a9abab58e5a upstream.

    Instead to being true/false, the "handled" is true/uninitialized.
    Presumably this doesn't cause that many problems in real life because
    normally we handle the IRQ.

    Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Milo Kim <milo.kim@ti.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/mfd/lp8788-irq.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mfd/lp8788-irq.c b/drivers/mfd/lp8788-irq.c
    index a87f2b5..ff4f845 100644
    --- a/drivers/mfd/lp8788-irq.c
    +++ b/drivers/mfd/lp8788-irq.c
    @@ -112,7 +112,7 @@ static irqreturn_t lp8788_irq_handler(int irq, void *ptr)
    struct lp8788_irq_data *irqd = ptr;
    struct lp8788 *lp = irqd->lp;
    u8 status[NUM_REGS], addr, mask;
    - bool handled;
    + bool handled = false;
    int i;

    if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))
    --
    2.7.4
    \
     
     \ /
      Last update: 2016-06-10 00:01    [W:4.234 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site