lkml.org 
[lkml]   [2016]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled

> The coherency is not dropped here. dma_map/unmap used
> makes the buffer coherent before passing it to
> dmaengine. Previously it was not required.
> I can add this in description if its not clear.

Please do.

>
> >> @@ -1268,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
> >> }
> >> }
> >>
> >> + idx = 0;
> >> +
> >
> >This looks like an unrelated change.
> Ha, wrong. This should have been in a separate patch.

Exactly this is what I meant with "unrelated" :)

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-06-09 23:21    [W:0.041 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site