lkml.org 
[lkml]   [2016]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/10] mm, oom: kill all tasks sharing the mm
On Wed 08-06-16 15:51:20, David Rientjes wrote:
> On Wed, 8 Jun 2016, Michal Hocko wrote:
>
> > > Why is the patch asking users to report oom killing of a process that
> > > raced with setting /proc/pid/oom_score_adj to OOM_SCORE_ADJ_MIN? What is
> > > possibly actionable about it?
> >
> > Well, the primary point is to know whether such races happen in the real
> > loads and whether they actually matter. If yes we can harden the locking
> > or come up with a less racy solutions.
>
> A thread being set to oom disabled while racing with the oom killer
> obviously isn't a concern: it could very well be set to oom disabled after
> the SIGKILL is sent and before the signal is handled, and that's not even
> fixable without unneeded complexity because we don't know the source of
> the SIGKILL. Please remove the printk entirely.

OK, if you find it more confusing than useful I will not insist.

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2016-06-09 09:21    [W:0.061 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site