Messages in this thread | | | Date | Thu, 9 Jun 2016 14:42:25 +1000 | From | Sam Bobroff <> | Subject | Re: [PATCH v5 08/11] powerpc/powernv: Add platform support for stop instruction |
| |
On Thu, Jun 02, 2016 at 07:38:58AM -0500, Shreyas B. Prabhu wrote:
...
> +/* Power Management - PSSCR Fields */
It might be nice to give the full name of the register, as below with the FPSCR.
> +#define PSSCR_RL_MASK 0x0000000F > +#define PSSCR_MTL_MASK 0x000000F0 > +#define PSSCR_TR_MASK 0x00000300 > +#define PSSCR_PSLL_MASK 0x000F0000 > +#define PSSCR_EC 0x00100000 > +#define PSSCR_ESL 0x00200000 > +#define PSSCR_SD 0x00400000 > + > + > /* Floating Point Status and Control Register (FPSCR) Fields */
Cheers, Sam.
| |