lkml.org 
[lkml]   [2016]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM
On Wed, Jun 08, 2016 at 09:40:11AM -0700, Brian Norris wrote:
> On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote:
> > With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM
> > it returns char *. Let's make that consistent. Also drop the
> > incorrect/inconsistent comment about char * above the nvmem_cell_read()
> > definition.
> >
> > drivers/thermal/mtk_thermal.c is already working around this by casting
> > to (u32 *).
> >
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>
> Seems Guenter submitted the same thing a week ago, with no response:
>
> https://patchwork.kernel.org/patch/9148325/
>
> I'll selfishly suggest that mine is better, since it also corrects the
> comments :)
>
Perfectly fine with me.

Guenter

\
 
 \ /
  Last update: 2016-06-08 20:01    [W:0.315 / U:1.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site