lkml.org 
[lkml]   [2016]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets


On Wed, 8 Jun 2016, Thomas Hellstrom wrote:

> > mss = rcdlro->mss;
> > if (unlikely(segCnt <= 1))
> > segCnt = 0;
>
> Based on this code, it looks like it can handle the case without taking
> down the kernel completely, so instead of a
> "BUG_ON", would it make sense with a WARN_ON_ONCE() or WARN_ON()?

Thanks for the review Thomas. I fixed the code to use WARN_ON_ONCE. Sent
out revised patch.

\
 
 \ /
  Last update: 2016-06-08 17:01    [W:0.083 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site