lkml.org 
[lkml]   [2016]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: light: gp2ap020a00f: use iio helper function to lock direct mode
Hi Alison,

On 06/08/2016 02:19 AM, Alison Schofield wrote:
> Replace the code that guarantees the device stays in direct mode
> with iio_device_claim_direct_mode() which does same. Includes a
> tiny bit of refactoring (single case -> if) and simplified return
> flow.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> ---
> drivers/iio/light/gp2ap020a00f.c | 18 +++++-------------
> 1 file changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
> index 6d41086..af73af3 100644
> --- a/drivers/iio/light/gp2ap020a00f.c
> +++ b/drivers/iio/light/gp2ap020a00f.c
> @@ -1287,22 +1287,14 @@ static int gp2ap020a00f_read_raw(struct iio_dev *indio_dev,
> struct gp2ap020a00f_data *data = iio_priv(indio_dev);
> int err = -EINVAL;
>
> - mutex_lock(&data->lock);
> -
> - switch (mask) {
> - case IIO_CHAN_INFO_RAW:
> - if (iio_buffer_enabled(indio_dev)) {
> - err = -EBUSY;
> - goto error_unlock;
> - }
> + if (mask == IIO_CHAN_INFO_RAW) {
> + err = iio_device_claim_direct_mode(indio_dev);
> + if (err)
> + return err;
>
> err = gp2ap020a00f_read_channel(data, chan, val);
> - break;
> + iio_device_release_direct_mode(indio_dev);
> }
> -
> -error_unlock:
> - mutex_unlock(&data->lock);
> -
> return err < 0 ? err : IIO_VAL_INT;
> }
>
>

Nice patch.

Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>

--
Best regards,
Jacek Anaszewski

\
 
 \ /
  Last update: 2016-06-08 09:41    [W:0.053 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site