lkml.org 
[lkml]   [2016]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 04/20] drm: exynos: Rely on the default ->best_encoder() behavior
    Date
    We have 1:1 relationship between connectors and encoders and the driver
    is relying on the atomic helpers: we can drop the custom ->best_encoder()
    implementations and let the core call drm_atomic_helper_best_encoder()
    for us.

    Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
    ---
    drivers/gpu/drm/exynos/exynos_drm_dpi.c | 9 ---------
    drivers/gpu/drm/exynos/exynos_drm_dsi.c | 9 ---------
    drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 --------
    drivers/gpu/drm/exynos/exynos_hdmi.c | 8 --------
    4 files changed, 34 deletions(-)

    diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
    index 5e38e74..ad6b73c 100644
    --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
    +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
    @@ -93,17 +93,8 @@ static int exynos_dpi_get_modes(struct drm_connector *connector)
    return 0;
    }

    -static struct drm_encoder *
    -exynos_dpi_best_encoder(struct drm_connector *connector)
    -{
    - struct exynos_dpi *ctx = connector_to_dpi(connector);
    -
    - return &ctx->encoder;
    -}
    -
    static const struct drm_connector_helper_funcs exynos_dpi_connector_helper_funcs = {
    .get_modes = exynos_dpi_get_modes,
    - .best_encoder = exynos_dpi_best_encoder,
    };

    static int exynos_dpi_create_connector(struct drm_encoder *encoder)
    diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
    index 601ecf8..e07cb1f 100644
    --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
    +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
    @@ -1566,17 +1566,8 @@ static int exynos_dsi_get_modes(struct drm_connector *connector)
    return 0;
    }

    -static struct drm_encoder *
    -exynos_dsi_best_encoder(struct drm_connector *connector)
    -{
    - struct exynos_dsi *dsi = connector_to_dsi(connector);
    -
    - return &dsi->encoder;
    -}
    -
    static const struct drm_connector_helper_funcs exynos_dsi_connector_helper_funcs = {
    .get_modes = exynos_dsi_get_modes,
    - .best_encoder = exynos_dsi_best_encoder,
    };

    static int exynos_dsi_create_connector(struct drm_encoder *encoder)
    diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
    index 608b0af..e8f6c92 100644
    --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
    +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
    @@ -378,16 +378,8 @@ static int vidi_get_modes(struct drm_connector *connector)
    return drm_add_edid_modes(connector, edid);
    }

    -static struct drm_encoder *vidi_best_encoder(struct drm_connector *connector)
    -{
    - struct vidi_context *ctx = ctx_from_connector(connector);
    -
    - return &ctx->encoder;
    -}
    -
    static const struct drm_connector_helper_funcs vidi_connector_helper_funcs = {
    .get_modes = vidi_get_modes,
    - .best_encoder = vidi_best_encoder,
    };

    static int vidi_create_connector(struct drm_encoder *encoder)
    diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
    index 58de5a4..1625d7c 100644
    --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
    +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
    @@ -937,17 +937,9 @@ static int hdmi_mode_valid(struct drm_connector *connector,
    return MODE_OK;
    }

    -static struct drm_encoder *hdmi_best_encoder(struct drm_connector *connector)
    -{
    - struct hdmi_context *hdata = connector_to_hdmi(connector);
    -
    - return &hdata->encoder;
    -}
    -
    static const struct drm_connector_helper_funcs hdmi_connector_helper_funcs = {
    .get_modes = hdmi_get_modes,
    .mode_valid = hdmi_mode_valid,
    - .best_encoder = hdmi_best_encoder,
    };

    static int hdmi_create_connector(struct drm_encoder *encoder)
    --
    2.7.4
    \
     
     \ /
      Last update: 2016-06-07 14:21    [W:5.009 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site