lkml.org 
[lkml]   [2016]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 2/2] crypto : async implementation for sha1-mb
On Thu, Jun 02, 2016 at 07:53:50PM -0700, Megha Dey wrote:
>
> + struct ahash_alg *shash = crypto_ahash_alg(tfm);
>
> /* alignment is to be done by multi-buffer crypto algorithm if needed */
>
> - return shash->finup(desc, NULL, 0, req->result);
> + return shash->finup(desc);

You're still poking in the guts of the API. Now that it's a real
ahash you don't need to do that.

Just do crypto_ahash_finup. That way you don't need to export
crypto_ahsh_alg either.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2016-06-07 12:41    [W:0.222 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site