Messages in this thread | | | Date | Tue, 7 Jun 2016 11:15:46 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] perf/core: make account/unaccount_sb_event consistent |
| |
On Wed, Jun 01, 2016 at 12:33:05PM -0700, David Carrillo-Cisneros wrote: > unaccount_pmu_sb_event did not check for attributes in event->attr > before calling detach_sb_event, while account_pmu_event did. > > This caused NULL pointer reference in cgroup events that did not > have any of the attributes checked by account_pmu_event. > > To trigger the bug just wait for a cgroup event to terminate, e.g.: > > $ mkdir /dev/cgroup/devices/test > $ perf stat -e cycles -a -G test sleep 0 > > ... see crash ... > > Patch rebased on peterz/queue/perf/core . > > Reviewed-by: Stephane Eranian <eranian@google.com> > Signed-off-by: David Carrillo-Cisneros <davidcc@google.com> > --- > kernel/events/core.c | 34 ++++++++++++++++++---------------- > 1 file changed, 18 insertions(+), 16 deletions(-)
Tested-by: Borislav Petkov <bp@suse.de>
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |