Messages in this thread | | | Date | Wed, 8 Jun 2016 02:16:54 +0800 | From | Yuyang Du <> | Subject | Re: [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group |
| |
On Tue, Jun 07, 2016 at 10:09:14AM +0200, Vincent Guittot wrote: > >> A much more simple solution would be > >> to prevent last_update_time to be initialized with this special value. > >> We can initialize the last_update_time of a sched_entity to 1 as an > >> example which is easier than these changes. > > > > Then at least, we must differentiate CONFIG_FAIR_GROUP_SCHED and > > !CONFIG_FAIR_GROUP_SCHED. And I am not sure whether this is a simpler > > Why do you want to differentiate ? we already have > sa->last_update_time = 0; in init_entity_runnable_average. We just > have to change it by sa->last_update_time = 1;
If !CONFIG_FAIR_GROUP_SCHED, we don't have task_move_group_fair(). If last_update_time != 0, we won't attach it for new task. Correct?
| |