lkml.org 
[lkml]   [2016]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scsi: ufs: fix potential memory leak
At 2016-06-08 03:12:08, "James Bottomley" <James.Bottomley@HansenPartnership.com> wrote:
>On Wed, 2016-06-08 at 02:00 +0800, Tiezhu Yang wrote:
>> There exists potential memory leak in ufshcd_parse_clock_info(),
>> this patch fixes it.
>
>What makes you think there's a leak here?  These are all devm_
>allocations, so they're all freed when the device is.  If an error is
>returned, the device is released and the memory freed.
>
>You can argue that on successful initialization, there's no need to
>keep the clkfreq array but this patch isn't the way you'd change that.
>
>James
>
OK, thanks. I will send a v2 patch.
\
 
 \ /
  Last update: 2016-06-08 01:41    [W:0.046 / U:23.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site