lkml.org 
[lkml]   [2016]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation
From
Date
On Mon, 2016-06-06 at 15:48 -0400, Johannes Weiner wrote:

> +void lru_cache_putback(struct page *page)
> +{
> + struct pagevec *pvec = &get_cpu_var(lru_putback_pvec);
> +
> + get_page(page);
> + if (!pagevec_space(pvec))
> + __pagevec_lru_add(pvec, false);
> + pagevec_add(pvec, page);
> + put_cpu_var(lru_putback_pvec);
> +}
>

Wait a moment.

So now we have a putback_lru_page, which does adjust
the statistics, and an lru_cache_putback which does
not?

This function could use a name that is not as similar
to its counterpart :)

--
All Rights Reversed.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-06-07 00:21    [W:0.263 / U:3.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site