Messages in this thread | | | Subject | Re: [PATCH 1/2] lib: hexdump: use a look-up table to do hex_to_bin | From | Joe Perches <> | Date | Thu, 30 Jun 2016 13:06:26 -0700 |
| |
On Thu, 2016-06-30 at 21:42 +0200, Geert Uytterhoeven wrote: > Hi Joe,
Hi Geert.
> On Thu, Jun 30, 2016 at 9:26 PM, Joe Perches <joe@perches.com> wrote: [] > > Perhaps _tolower should be used a bit more in lib [] > No, we do care about non-alphabetical characters here. > Using _tolower is equivalent to ignoring bit 5 in each byte of the string.
Yeah, that can't work. Rasmus V wrote the same thing to me offline.
| |