lkml.org 
[lkml]   [2016]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation.
On Fri, Jun 17, 2016 at 03:43:57PM +0800, Garlic Tseng wrote:

> +static int mt2701_afe_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id,
> + int div)
> +{

Why are we adding a set_clkdiv() operation? I would expect the driver
to be able to figure things out automatically.

> + case DIV_ID_MCLK_TO_BCK:
> + afe_priv->i2s_path[i2s_num].div_mclk_to_bck = div;
> + break;
> + case DIV_ID_BCK_TO_LRCK:
> + afe_priv->i2s_path[i2s_num].div_bck_to_lrck = div;
> + break;

Especially in the case where we're configuring LRCLK, that's trivial
when we know the sample rate which we have to know anyway.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-06-30 14:41    [W:0.102 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site