Messages in this thread | | | Date | Wed, 29 Jun 2016 20:13:22 +0100 | From | Mark Brown <> | Subject | Re: [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation. |
| |
On Fri, Jun 17, 2016 at 03:43:57PM +0800, Garlic Tseng wrote:
> +static int mt2701_afe_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id, > + int div) > +{
Why are we adding a set_clkdiv() operation? I would expect the driver to be able to figure things out automatically.
> + case DIV_ID_MCLK_TO_BCK: > + afe_priv->i2s_path[i2s_num].div_mclk_to_bck = div; > + break; > + case DIV_ID_BCK_TO_LRCK: > + afe_priv->i2s_path[i2s_num].div_bck_to_lrck = div; > + break;
Especially in the case where we're configuring LRCLK, that's trivial when we know the sample rate which we have to know anyway. [unhandled content-type:application/pgp-signature] | |