Messages in this thread Patch in this message | | | From | "Pranay Kr. Srivastava" <> | Subject | [PATCH v4 1/5]nbd: cleanup nbd_set_socket | Date | Thu, 30 Jun 2016 14:02:01 +0300 |
| |
From: "Pranay Kr. Srivastava" <pranaykumar.srivastava@cognizant.com>
This patch 1) uses spin_lock instead of irq version.
2) removes the goto statement in case a socket is already assigned with simple if-else statement.
Signed-off-by: Pranay Kr. Srivastava <pranjas@gmail.com> --- drivers/block/nbd.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 56f7f5d..766c401 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -643,17 +643,12 @@ static int nbd_set_socket(struct nbd_device *nbd, struct socket *sock) { int ret = 0; - spin_lock_irq(&nbd->sock_lock); - - if (nbd->sock) { + spin_lock(&nbd->sock_lock); + if (nbd->sock) ret = -EBUSY; - goto out; - } - - nbd->sock = sock; - -out: - spin_unlock_irq(&nbd->sock_lock); + else + nbd->sock = sock; + spin_unlock(&nbd->sock_lock); return ret; } -- 1.9.1
| |