Messages in this thread | | | Date | Wed, 29 Jun 2016 23:09:58 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH] power: qcom-smbb: add extcon dependency |
| |
Hi,
On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote: > On 06/29/2016 07:38 AM, Sebastian Reichel wrote: > > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote: > >> Building the smbb driver without extcon results in a link failure: > >> > >> drivers/power/built-in.o: In function `smbb_usb_valid_handler': > >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_' > >> drivers/power/built-in.o: In function `smbb_charger_probe': > >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate' > >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register' > >> > >> This adds a Kconfig dependency. > >> > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver") > > extcon use was only recently introduced so this should be > > Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable > detection")
Right, I didn't notice the Fixes line is wrong. Since I will have to rebase now, I will just squash this into 0b7fe26ae602.
-- Sebastian [unhandled content-type:application/pgp-signature] | |