lkml.org 
[lkml]   [2016]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.
    Date
    Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young:
    > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote:
    > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young:
    > > > On 06/27/16 at 04:21pm, Dave Young wrote:
    > > > Using one argument for both sounds more reasonable than using a
    > > > separate
    > > > argument for memory walk..
    > >
    > > I agree. This patch doesn't use a separate top_down argument, it's the
    > > same patch I sent earlier except that the comments to struct kexec_buf
    > > are in patch 2/9. What do you think?
    >
    > It looks good except one nitpick inline..
    >
    >
    > > +/**
    > > + * kexec_locate_mem_hole - find free memory to load segment or use in
    > > purgatory

    > It is not necessary to use only for purgatory load..

    Ok, what about this?

    /**
    * kexec_locate_mem_hole - find free memory in a given kimage.


    []'s
    Thiago Jung Bauermann
    IBM Linux Technology Center

    \
     
     \ /
      Last update: 2016-06-29 23:41    [W:8.364 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site