lkml.org 
[lkml]   [2016]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Xen-devel] [PATCH] x86/xen: Use DIV_ROUND_UP
From
Date
On 29/06/16 17:34, Jan Beulich wrote:
>>>> On 29.06.16 at 17:00, <amitoj1606@gmail.com> wrote:
>> --- a/arch/x86/xen/enlighten.c
>> +++ b/arch/x86/xen/enlighten.c
>> @@ -591,7 +591,7 @@ static void xen_load_gdt(const struct desc_ptr *dtr)
>> {
>> unsigned long va = dtr->address;
>> unsigned int size = dtr->size + 1;
>> - unsigned pages = (size + PAGE_SIZE - 1) / PAGE_SIZE;
>> + unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE);
>> unsigned long frames[pages];
>> int f;
>>
>> @@ -640,7 +640,7 @@ static void __init xen_load_gdt_boot(const struct desc_ptr *dtr)
>> {
>> unsigned long va = dtr->address;
>> unsigned int size = dtr->size + 1;
>> - unsigned pages = (size + PAGE_SIZE - 1) / PAGE_SIZE;
>> + unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE);
>> unsigned long frames[pages];
>> int f;
>>
>
> Perhaps even more readable would be PFN_DOWN()?

Or PFN_UP() to be correct?


Juergen

\
 
 \ /
  Last update: 2016-06-29 18:21    [W:0.090 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site