lkml.org 
[lkml]   [2016]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 06/11] staging: fsl-mc: make fsl_mc_is_root_dprc() global
From
Date
On 22/06/16 23:40, Stuart Yoder wrote:
> make fsl_mc_is_root_dprc() global so that the dprc driver
> can use it
>
> Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
> ---
> drivers/staging/fsl-mc/bus/mc-bus.c | 28 +++++++++++++---------------
> drivers/staging/fsl-mc/include/mc.h | 2 ++
> 2 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c b/drivers/staging/fsl-mc/bus/mc-bus.c
> index e975adc..a49186e 100644
> --- a/drivers/staging/fsl-mc/bus/mc-bus.c
> +++ b/drivers/staging/fsl-mc/bus/mc-bus.c
> @@ -24,8 +24,6 @@
>
> static struct kmem_cache *mc_dev_cache;
>
> -static bool fsl_mc_is_root_dprc(struct device *dev);
> -
> /**
> * fsl_mc_bus_match - device to driver matching callback
> * @dev: the MC object device structure to match against
> @@ -247,19 +245,6 @@ static void fsl_mc_get_root_dprc(struct device *dev,
> }
> }
>
> -/**
> - * fsl_mc_is_root_dprc - function to check if a given device is a root dprc
> - */
> -static bool fsl_mc_is_root_dprc(struct device *dev)
> -{
> - struct device *root_dprc_dev;
> -
> - fsl_mc_get_root_dprc(dev, &root_dprc_dev);
> - if (!root_dprc_dev)
> - return false;
> - return dev == root_dprc_dev;
> -}
> -
> static int get_dprc_attr(struct fsl_mc_io *mc_io,
> int container_id, struct dprc_attributes *attr)
> {
> @@ -424,6 +409,19 @@ error_cleanup_regions:
> }
>
> /**
> + * fsl_mc_is_root_dprc - function to check if a given device is a root dprc
> + */
> +bool fsl_mc_is_root_dprc(struct device *dev)
> +{
> + struct device *root_dprc_dev;
> +
> + fsl_mc_get_root_dprc(dev, &root_dprc_dev);
> + if (!root_dprc_dev)
> + return false;
> + return dev == root_dprc_dev;
> +}
> +
> +/**

Is there any reason why apart from deleting "static" you move
fsl_mc_is_root to a different line?

Regards,
Matthias

> * Add a newly discovered MC object device to be visible in Linux
> */
> int fsl_mc_device_add(struct dprc_obj_desc *obj_desc,
> diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h
> index a9a9d23..853cbf3 100644
> --- a/drivers/staging/fsl-mc/include/mc.h
> +++ b/drivers/staging/fsl-mc/include/mc.h
> @@ -207,6 +207,8 @@ int __must_check fsl_mc_allocate_irqs(struct fsl_mc_device *mc_dev);
>
> void fsl_mc_free_irqs(struct fsl_mc_device *mc_dev);
>
> +bool fsl_mc_is_root_dprc(struct device *dev);
> +
> extern struct bus_type fsl_mc_bus_type;
>
> #endif /* _FSL_MC_H_ */
>

\
 
 \ /
  Last update: 2016-06-29 17:01    [W:0.406 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site