Messages in this thread | | | From | Stewart Smith <> | Subject | Re: [PATCH V5 2/3] powerpc/opal: Add inline function to get rc from an ASYNC_COMP opal_msg | Date | Wed, 29 Jun 2016 19:07:09 +1000 |
| |
Suraj Jitindar Singh <sjitindarsingh@gmail.com> writes: > --- a/arch/powerpc/include/asm/opal.h > +++ b/arch/powerpc/include/asm/opal.h > @@ -276,6 +276,14 @@ extern int opal_error_code(int rc); > > ssize_t opal_msglog_copy(char *to, loff_t pos, size_t count); > > +static inline int opal_get_async_rc(struct opal_msg msg) > +{ > + if (msg.msg_type != OPAL_MSG_ASYNC_COMP) > + return OPAL_PARAMETER;
Should instead be WARN_ON or BUG_ON ? Is there *ever* a situation where calling opal_get_async_rc on a non-OPAL_MSG_ASYNC_COMP is a not both a dumb idea and a bug?
otherwise (including if above change is made) Acked-by: Stewart Smith <stewart@linux.vnet.ibm.com>
-- Stewart Smith OPAL Architect, IBM.
| |