lkml.org 
[lkml]   [2016]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file
    On Tue, Jun 28, 2016 at 03:34:40PM -0400, Jon Mason wrote:
    > Move the BCMA MDIO phy into a separate file, as it is very tightly
    > coupled with the BCMA bus. This will help with the upcoming BCMA
    > removal from the bgmac driver. Optimally, this should be moved into
    > phy drivers, but it is too tightly coupled with the bgmac driver to
    > effectively move it without more changes to the driver.

    It is quite common to have the MII bus driver as a sub driver of the
    MAC driver, if they are tightly coupled. The MII drivers in
    drivers/net/phy are all independent of the MAC driver and use a
    different space in the register sets. This does not seem the case
    here, so i think the split you have made is O.K, and i don't see a
    need to move it into phy.

    Andrew

    \
     
     \ /
      Last update: 2016-06-28 22:41    [W:4.188 / U:1.576 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site